Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.gnmi): set max gRPC message size #12495

Merged
merged 2 commits into from
Jan 27, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Jan 11, 2023

Adds an option to let a user set the max gRPC message size. By default, this is set to 4MB and allows a user to receive larger messages if required by the end device.

fixes: #12463

Adds an option to let a user set the max gRPC message size. By default,
this is set to 4MB and allows a user to receive larger messages if
required by the end device.

fixes: influxdata#12463
@telegraf-tiger telegraf-tiger bot added area/gnmi feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jan 11, 2023
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jan 25, 2023
@powersj powersj requested a review from srebhan January 25, 2023 20:18
@powersj powersj marked this pull request as ready for review January 25, 2023 20:18
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I really want the size to be config.Size in order to make it more human-readable.

plugins/inputs/gnmi/gnmi.go Outdated Show resolved Hide resolved
plugins/inputs/gnmi/README.md Outdated Show resolved Hide resolved
@telegraf-tiger
Copy link
Contributor

Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @powersj!

@srebhan srebhan merged commit d3e1f95 into influxdata:master Jan 27, 2023
@mohsin106
Copy link

I downloaded the Alpine Docker image version 1.25.1 and currently getting this error:

Mon, Feb 6 2023 4:24:04 pm | 2023-02-06T21:24:04Z I! Using config file: /etc/telegraf/telegraf.conf
Mon, Feb 6 2023 4:24:04 pm | 2023-02-06T21:24:04Z E! error loading config file /etc/telegraf/telegraf.conf: plugin inputs.gnmi: line 12: configuration specified the fields ["max_msg_size"], but they weren't used

Is this because the network device that I'm connecting to doesn't recognize the "max_msg_size" parameter?

My gNMI config looks like this:

[[inputs.gnmi]]
  addresses = ["10.30.45.50:10161"]
  username = "$user"
  password = "$password"
  redial = "10s"
  enable_tls = true
  insecure_skip_verify = true
  max_msg_size = "10MB"
  [[inputs.gnmi.subscription]]
    name = "test"
    path = "/components"
    subscription_mode = "sample"
    origin = "openconfig-platform"
    sample_interval = "10s"

@powersj
Copy link
Contributor Author

powersj commented Feb 6, 2023

I downloaded the Alpine Docker image version 1.25.1 and currently getting this error:

As this is a feature it will go into 1.26 next month, not 1.25.1. You can also grab a nightly docker image and give it a try there as well.

@powersj powersj deleted the fix/12463 branch February 6, 2023 21:36
@srebhan srebhan added this to the v1.26.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gnmi feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose option to increase max message size in gNMI plugin.
3 participants