-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(outputs.elasticsearch): Allow settings extra headers for elasticsearch output #15477
feat(outputs.elasticsearch): Allow settings extra headers for elasticsearch output #15477
Conversation
Thanks so much for the pull request! |
!signed-cla |
36bd379
to
043e20a
Compare
043e20a
to
fab22b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndrewChubatiuk thanks for your contribution! The code looks good, just one naming suggestion from my side...
# [outputs.elasticsearch.extra_headers] | ||
# "X-Custom-Header" = "custom-value" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we name this just headers
please? I don't see where this is "extra"...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just updated
fab22b2
to
1678da6
Compare
1678da6
to
56fd624
Compare
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm grabbing this for the release. Sven's comment was resolved so considering this approved.
Summary
Allow settings extra headers for elasticsearch output's client
Checklist
Related issues
resolves #15476