allow changing jolokia delimiter #2255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrc
approved these changes
Jan 12, 2017
njwhite
pushed a commit
to njwhite/telegraf
that referenced
this pull request
Jan 31, 2017
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
This allows changing the delimiter jolokia uses for concatenating metric names & attribute keys. It is very common for an attribute key to contain an underscore, thus using an underscore as the delimiter makes the field names rather ambiguous.
Personally I use a dot (
.) as my delimiter, as it is very rare to see a dot in an attribute key, but I've been doing so by explicitly specifying each attribute as a separate[inputs.jolokia.metric].