Improve win_perf_counters on non English systems #2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks again @PierreF |
1 task
njwhite
pushed a commit
to njwhite/telegraf
that referenced
this pull request
Jan 31, 2017
mlindes
pushed a commit
to Comcast/telegraf
that referenced
this pull request
Feb 6, 2017
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
gab-satchi
pushed a commit
to gab-satchi/kubernetes
that referenced
this pull request
Oct 28, 2019
The `ValidatePath` syscall only operates in a localized language mode, however `AddEnglishCounter` always works with English-localized counter names. This means that on non-English systems, the counter will work but will fail validation. The only solution is to not validate the counter. There is no corresponding `ValidateEnglishPath` syscall. `CollectQueryData` will still error if the counter is invalid. Reference: influxdata/telegraf#2261
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
Another fix for #1730. This PR allows default configuration (with English names, like "Processor") to work on non-English Windows.
It re-add PreVistaSupport (as it use PdhAddEnglishCounter which existing only since Vista). It removes the validation using PdhValidatePath that only support localized names.
A validation is added by calling PdhCollectQueryData during configuration. This give fewer information than PdhValidatePath, it only say if the query exist or not. We no longer know if it was the object, instance or counter that does not exists.