-
Notifications
You must be signed in to change notification settings - Fork 39.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix windows performance counter error on Non-English environemnt #84156
Fix windows performance counter error on Non-English environemnt #84156
Conversation
Hi @wawa0210. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@benmoss Can you review this pr |
/approve |
/ok-to-test |
FYI @PatrickLang |
/uncc |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benmoss, wawa0210, yujuhong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@benmoss @yujuhong @PatrickLang Since this issue exists in all historical versions and will cause non-English versions of windows kubelets to not work properly, do I need to cherry-pick to 1.14, 1.15, 1.16 at the same time? I can go to cherry-pick if needed. |
Yes, I think if you want to you should cherry-pick this to other versions. There's documentation on this process here https://github.com/kubernetes/community/blob/master/contributors/devel/sig-release/cherry-picks.md |
Done, can you help me review these cherry-picks? |
…56-upstream-release-1.16 Automated cherry pick of #84156: fix windows performance counter father information failed
…56-upstream-release-1.14 Automated cherry pick of #84156: fix windows performance counter father information failed
…56-upstream-release-1.15 Automated cherry pick of #84156: fix windows performance counter father information failed
/kind bug
What this PR does / why we need it:
This issue can cause the kubelet not to start properly and cannot provide services.
The
ValidatePath
syscall only operates in a localized language mode,however AddEnglishCounter always works with English-localized counter
names. This means that on non-English systems, the counter will work but
will fail validation.
The only solution is to not validate the counter. There is no
corresponding
ValidateEnglishPath
syscall.CollectQueryData
willstill error if the counter is invalid.
Reference: influxdata/telegraf#2261
This is the official example of Microsoft npd, and also does not need to call the PdhValidatePath method.
https://docs.microsoft.com/en-us/windows/win32/perfctrs/browsing-performance-counters
Which issue(s) this PR fixes:
Fixes #74173
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig windows