use MAX() instead of SUM() for latency measurements #3471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using SUM() results in multi-second latency measurements when multiple files are used for a database - which is typical for tempdb. Using MAX() gives a more meaningful measurement. AVG() can be used as well but will hide problems when one of the db files encounters a problem. Example: File0: 30ms File1: 40ms File2: 50ms File3: 60ms File4: 70ms File5: 80ms File6: 90ms SUM (currently what is reported) results in 420 ms latency, MAX (current proposal) in 90ms and AVG in 60ms
use MAX() instead of SUM() for latency measurements
|
@zensqlmonitor @m82labs Could you help review this change? |
m82labs
approved these changes
Nov 16, 2017
aromeyer
pushed a commit
to aromeyer/telegraf
that referenced
this pull request
May 19, 2018
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using SUM() results in multi-second latency measurements when multiple files are used for a database - which is typical for tempdb. Using MAX() gives a more meaningful measurement. AVG() can be used as well but will hide problems when one of the db files encounters a problem. Example:
File0: 30ms
File1: 40ms
File2: 50ms
File3: 60ms
File4: 70ms
File5: 80ms
File6: 90ms
SUM (currently what is reported) results in 420 ms latency, MAX (current proposal) in 90ms and AVG in 60ms