Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deliver_get in RabbitMQ #3633

Merged
merged 1 commit into from
Jan 3, 2018
Merged

Fix deliver_get in RabbitMQ #3633

merged 1 commit into from
Jan 3, 2018

Conversation

kerams
Copy link
Contributor

@kerams kerams commented Jan 3, 2018

The json output has apparently never been parsed correctly.

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson danielnelson added this to the 1.6.0 milestone Jan 3, 2018
@danielnelson
Copy link
Contributor

I think this value is reported in rabbitmq_overview as messages_delivered and in rabbitmq_queue as messages_deliver_get. Can you explain what this change does?

@kerams
Copy link
Contributor Author

kerams commented Jan 3, 2018

These are 2 separate values (https://pulse.mozilla.org/doc/stats.html). In #3596 I exposed messages_deliver_get into the rabbitmq_overview measurement, but it turns out it's always reported as 0 (in rabbitmq_queue too) because of the bug that I am fixing in this PR.

@kerams
Copy link
Contributor Author

kerams commented Jan 3, 2018

In other words, both messages_delivered and messages_delivered_get should be available in rabbitmq_overview as well as rabbitmq_queue, but the latter is currently always 0.

@danielnelson
Copy link
Contributor

I see, because of the underscore we need the struct tag.

@danielnelson danielnelson modified the milestones: 1.6.0, 1.5.1 Jan 3, 2018
@danielnelson danielnelson merged commit acea710 into influxdata:master Jan 3, 2018
danielnelson pushed a commit that referenced this pull request Jan 3, 2018
@danielnelson danielnelson added fix pr to fix corresponding bug area/rabbitmq labels Jan 3, 2018
@kerams kerams deleted the fix-rabbitq-deliver-get branch January 3, 2018 21:45
maxunt pushed a commit that referenced this pull request Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rabbitmq fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants