Bugfix/procstat adds new procstat metric about pgrep search #4307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plugins/inputs/procstat/pgrep.go
Outdated
| if err != nil { | ||
| return "", fmt.Errorf("Error running %s: %s", path, err) | ||
| //return "", fmt.Errorf("Error running %s: %s", path, err) | ||
| return "", fmt.Errorf("Error executing command: %v %v, err: %s", path, args, err) |
There was a problem hiding this comment.
Keep only the old error message.
| @@ -369,3 +370,39 @@ func TestGather_cgroupPIDs(t *testing.T) { | |||
| assert.Equal(t, []PID{1234, 5678}, pids) | |||
| assert.Equal(t, td, tags["cgroup"]) | |||
| } | |||
|
|
|||
| func TestExitStatus(t *testing.T) { | |||
| out, err := exec.Command("pgrep", "-G", "sys").Output() | |||
There was a problem hiding this comment.
This command could return different results on different systems, so it could create random failures, perhaps you can make the needed error by hand. Also, it tests a function in internal/internal.go so it should be placed in internal/internal_test.go
|
|
||
| func TestNoPgrepResults(t *testing.T) { | ||
| p := Procstat{ | ||
| PidFinder: "pgrep", |
There was a problem hiding this comment.
Same comment as above for this and the next test. You should be able to use testPgrep in this same file to fake the results.
|
|
||
| func TestExitStatus(t *testing.T) { | ||
| out, err := exec.Command("pgrep", "-G", "sys").Output() | ||
| t.Logf("cmd out: %v", out) |
There was a problem hiding this comment.
Remove any logging in the test cases, use assertions to document results.
danielnelson
added
feat
This was referenced Jun 21, 2018
mkboudreau
added a commit
to mkboudreau/telegraf
that referenced
this pull request
Jun 22, 2018
* origin: (39 commits) Document path tag in tail input Update changelog Added path tag to tail input plugin (influxdata#4292) Run windows tests with -short Fix postfix input handling of multi-level queues (influxdata#4333) Update changelog Add support for comma in logparser timestamp format (influxdata#4311) Update vendoring to dep from gdm (influxdata#4314) Update changelog Add new measurement with results of pgrep lookup to procstat input (influxdata#4307) Update changelog Add valuecounter aggregator plugin (influxdata#3523) Update changelog Update docker input documentation for container status Add container status tag to docker input (influxdata#4259) Drop CI support for Go 1.8 (influxdata#4309) Update changelog Fix selection of tags under nested objects in the JSON parser (influxdata#4284) Update changelog Add owner tag on partitions in burrow input (influxdata#4281) ...
maxunt
added a commit
that referenced
this pull request
Jun 26, 2018
rgitzel
pushed a commit
to rgitzel/telegraf
that referenced
this pull request
Oct 17, 2018
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs: