Add support for comma in timestamp format #4311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -186,6 +186,7 @@ func (p *Parser) Compile() error { | |||
|
|
|||
| // ParseLine is the primary function to process individual lines, returning the metrics | |||
| func (p *Parser) ParseLine(line string) (telegraf.Metric, error) { | |||
|
|
|||
There was a problem hiding this comment.
Undo these whitespace changes, so that git history will be a little easier to read.
| } | ||
|
|
||
| require.NoError(t, p.Compile()) | ||
| m, err := p.ParseLine("2018-02-21 13:10:34.555 successfulMatches=1") |
There was a problem hiding this comment.
Should have a comma separator in here right?
| @@ -293,6 +294,7 @@ func (p *Parser) ParseLine(line string) (telegraf.Metric, error) { | |||
| timestamp = time.Unix(0, iv) | |||
| } | |||
| case SYSLOG_TIMESTAMP: | |||
|
|
|||
There was a problem hiding this comment.
Undo whitespace change.
plugins/inputs/logparser/README.md
Outdated
| "reference time", which is `Mon Jan 2 15:04:05 -0700 MST 2006` | ||
| "reference time", which is `Mon Jan 2 15:04:05 -0700 MST 2006`. Both a comma | ||
| and a period are supported as a number separator. | ||
| EX: timestamp:ts-"2006-01-02 15:04:05.000" or timestamp:ts-"2006-01-02 15:04:05,000" |
There was a problem hiding this comment.
While you can have a comma in the parsed string, in the ts-"" format string it will have to be dot right now unless you replace it in the format string too.
danielnelson
added
feat
added 5 commits
June 18, 2018 18:03
Ayrdrie
force-pushed
the
logparser-comma-support
branch
from
0a3d635
to
5561af3
Compare
|
closes #3571 |
mkboudreau
added a commit
to mkboudreau/telegraf
that referenced
this pull request
Jun 22, 2018
* origin: (39 commits) Document path tag in tail input Update changelog Added path tag to tail input plugin (influxdata#4292) Run windows tests with -short Fix postfix input handling of multi-level queues (influxdata#4333) Update changelog Add support for comma in logparser timestamp format (influxdata#4311) Update vendoring to dep from gdm (influxdata#4314) Update changelog Add new measurement with results of pgrep lookup to procstat input (influxdata#4307) Update changelog Add valuecounter aggregator plugin (influxdata#3523) Update changelog Update docker input documentation for container status Add container status tag to docker input (influxdata#4259) Drop CI support for Go 1.8 (influxdata#4309) Update changelog Fix selection of tags under nested objects in the JSON parser (influxdata#4284) Update changelog Add owner tag on partitions in burrow input (influxdata#4281) ...
maxunt
pushed a commit
that referenced
this pull request
Jun 26, 2018
glinton
pushed a commit
that referenced
this pull request
Jun 26, 2018
rgitzel
pushed a commit
to rgitzel/telegraf
that referenced
this pull request
Oct 17, 2018
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs: