re-worked lowercase into a generic strings processor #4476
Conversation
plugins/processors/strings/README.md
Outdated
|
|
||
| ### Example Input: | ||
| ``` | ||
| iis_log,method=get,uri_stem=/API/HealthCheck cs-host="MIXEDCASE_host",referrer="-",ident="-",http_version=1.1,agent="UserAgent",resp_bytes=270i 1519652321000000000 |
There was a problem hiding this comment.
I assume this also works if the input method=GET? If so, update example input
plugins/processors/strings/README.md
Outdated
| tag = "method" | ||
|
|
||
| [[processors.strings.uppercase]] | ||
| key = "cs-host" |
There was a problem hiding this comment.
Should this be tag or field?
|
|
||
| type converter struct { | ||
| Tag string | ||
| Field string |
There was a problem hiding this comment.
run gofmt -w ./plugins/processors/strings; will also allow tests to run
|
@bsmaldon I opened a pr against your fork ada-foss#1 which I believe addresses the remaining issues. |
Use processor conventions from influxdata#4616
|
I don't totally understand the rationale of all the changes but understand the points about different feel of processors, I didn't really have my eye on the other processors as I was just thinking about my own requirements I guess. In any case I've checked it and it looks functionally the same so if you're happy with it like this then I'm happy too. |
|
@bsmaldon Can you run |
I'm re-opening this as a new pull request because I've rebased to clean up the history and don't see a way to update the original pull request. This is the implementation of the strings processor we've been talking about in pull request #3890.
Required for all PRs: