Fix translate empty tag values #5083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glinton
approved these changes
Dec 6, 2018
|
Also, don't forget to sign the CLA. |
|
I've already sign! Forgot to check! |
danielnelson
suggested changes
Dec 10, 2018
| dimensionNames = append(dimensionNames, tag.Key) | ||
| dimensionValues = append(dimensionValues, tag.Value) | ||
| if value == "" { | ||
| value = "<empty>" |
There was a problem hiding this comment.
Can dimensions be added with the value as the empty string instead of using a placeholder value?
There was a problem hiding this comment.
If we can't have empty strings at all, I'd like to try this instead:
diff --git a/plugins/outputs/azure_monitor/azure_monitor.go b/plugins/outputs/azure_monitor/azure_monitor.go
index 5c435ac0..1c933072 100644
--- a/plugins/outputs/azure_monitor/azure_monitor.go
+++ b/plugins/outputs/azure_monitor/azure_monitor.go
@@ -340,6 +340,9 @@ func hashIDWithTagKeysOnly(m telegraf.Metric) uint64 {
h.Write([]byte(m.Name()))
h.Write([]byte("\n"))
for _, tag := range m.TagList() {
+ if tag.Key == "" || tag.Value == "" {
+ continue
+ }
h.Write([]byte(tag.Key))
h.Write([]byte("\n"))
}There was a problem hiding this comment.
Yes. this implementation is better. I've tested here with success.
danielnelson
pushed a commit
that referenced
this pull request
Dec 13, 2018
(cherry picked from commit f794d5b)
trevorwhitney
pushed a commit
to trevorwhitney/telegraf
that referenced
this pull request
Feb 14, 2019
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
dupondje
pushed a commit
to dupondje/telegraf
that referenced
this pull request
Apr 22, 2019
bitcharmer
pushed a commit
to bitcharmer/telegraf
that referenced
this pull request
Oct 18, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #5063
Required for all PRs: