Run stop logic only if required #5144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| p.wg.Wait() | ||
| if p.MonitorPods { | ||
| p.cancel() | ||
| p.wg.Wait() |
There was a problem hiding this comment.
Always need to wait, if metrics are added after Stop is called the channel could be closed.
There was a problem hiding this comment.
Even if p.wg is only utilized if MonitorPods is set?
There was a problem hiding this comment.
I believe WaitGroup is always used, otherwise I would say no. Another option here that @goller mentioned was the null object pattern with cancel normally set to func() {}. This way you could always wait and wouldn't need to line up the booleans.
danielnelson
pushed a commit
that referenced
this pull request
Dec 14, 2018
(cherry picked from commit 891eff0)
trevorwhitney
pushed a commit
to trevorwhitney/telegraf
that referenced
this pull request
Feb 14, 2019
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
dupondje
pushed a commit
to dupondje/telegraf
that referenced
this pull request
Apr 22, 2019
bitcharmer
pushed a commit
to bitcharmer/telegraf
that referenced
this pull request
Oct 18, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5143