Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MongoDB plugin #54

Merged
merged 3 commits into from
Jul 21, 2015
Merged

Conversation

jipperinbham
Copy link
Contributor

This PR contains a few additional changes along with a MongoDB plugin:

  • testutil.Accumulator was using a Value and Values field and was using a specific one depending on whether the operation was Add vs AddValuesWithTime, this was causing tests that used AddValuesWithTime to not function properly so I removed Value and reworked how the Add function worked to be more inline with the actual Accumulator implementation.
  • I copied over stat_types.go from MongoDB Inc's mongo-tools project but removed any code that was requiring another dependency in that project as well as removed any unused code. That project is licensed under Apache V2 so I made note of the origination of work and any modifications in the file.

}
}
wg.Add(1)
go func(serv string) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is serv used in the function launched by the goroutine?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, it's not needed for the go routine

@jipperinbham
Copy link
Contributor Author

@otoolep I removed the unused serv variable as well as updated the sample config.toml and README

@otoolep
Copy link

otoolep commented Jul 9, 2015

Great, thanks.

On Tue, Jul 7, 2015 at 10:27 AM, JP Phillips notifications@github.com
wrote:

@otoolep https://github.com/otoolep I removed the unused serv variable
as well as updated the sample config.toml and README


Reply to this email directly or view it on GitHub
#54 (comment).

evanphx added a commit that referenced this pull request Jul 21, 2015
@evanphx evanphx merged commit b4e032d into influxdata:master Jul 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants