Base64-encoding/decoding parameters for Google Cloud PubSub plugins #5543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnelson
reviewed
Mar 6, 2019
There was a problem hiding this comment.
Just to be sure, the entire message is normally base64 encoded? Just double checking because I know in the pubsub push and in some synchronous pull examples only part of the JSON is encoded: https://cloud.google.com/pubsub/docs/pull#synchronous-pull
|
@danielnelson This is actually only setting encoded/decoded values for pubsub.Message.Data, which corresponds to the "data" field in a JSON representation of the message sent to the API. |
danielnelson
added
the
feat
danielnelson
pushed a commit
that referenced
this pull request
Mar 7, 2019
(cherry picked from commit dd67144)
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
dupondje
pushed a commit
to dupondje/telegraf
that referenced
this pull request
Apr 22, 2019
bitcharmer
pushed a commit
to bitcharmer/telegraf
that referenced
this pull request
Oct 18, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
This enables several GCP services that can and only output base64-encoded JSON to PubSub (and thus input into Telegraf/TICK). Enabled base-64 encoded for output of metrics just because symmetry is nice and it's suggested that PubSub wants base64-encoded data no matter what.