Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set per file csv parser to allow individual headers per file #6324

Closed
wants to merge 2 commits into from

Conversation

glinton
Copy link
Contributor

@glinton glinton commented Aug 28, 2019

One method to resolve #6318

@glinton glinton added the fix pr to fix corresponding bug label Aug 28, 2019
@danielnelson
Copy link
Contributor

Check out the tail plugin, we should do something similar.

@rkleivel
Copy link

rkleivel commented Apr 2, 2020

Is there any info as to if/when this fix will reach a release? I need to process files with varying numbers and orders of columns, and #6318 is a showstopper.
Thanks!

@srebhan
Copy link
Member

srebhan commented Nov 12, 2020

Let's get this rolling again. @glinton: I can reproduce the problem but it seems (after rebasing) that your approach does not fix the problem. Instead the field names are still wrong... I noticed that the pointers to the parsers in readMetric() are all the same. So can you please first rebase your patches and resolve the merge conflict. And second check that your approach solves #6318!? Thanks for your effort!

@ssoroka
Copy link
Contributor

ssoroka commented Nov 13, 2020

merged in #8400

@ssoroka ssoroka closed this Nov 13, 2020
@sspaink sspaink deleted the bugfix/6318 branch October 19, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

input.file plugin behavior with different input metrics files
5 participants