Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GNMI: Improve platform compatibility and corner case handling #6403

Merged
merged 1 commit into from
Sep 24, 2019
Merged

GNMI: Improve platform compatibility and corner case handling #6403

merged 1 commit into from
Sep 24, 2019

Conversation

sbyx
Copy link
Contributor

@sbyx sbyx commented Sep 17, 2019

This addresses three issues in the GNMI plugin:

  • Measurement names (aliases) are correctly generated for replies where the origin field is empty even though the request contained a non-empty origin. (This may fix Could not serialize metric: invalid name from cisco_telemetry_gnmi with gNMI interface on Arista #6391 but I cannot verify it for this platform, however it addresses the same issue with a device of a different platform I have access to).
  • It prevents Telegraf from crashing when a field has no value or one of a deprecated type.
  • It skips path elements with empty names instead of adding additional '/' to fields.

@sbyx
GNMI: Increase platform compatibility and corner case handling
d30206f 
This addresses three issues:
- Avoid crashing when a field has no value or one of deprecated type
- Emit measurement names correctly for replies with empty origin
- Skip paths with empty names instead of adding a '/'
@danielnelson danielnelson mentioned this pull request Sep 17, 2019
Closed
@danielnelson danielnelson added the fix pr to fix corresponding bug label Sep 17, 2019
@danielnelson danielnelson added this to the 1.12.2 milestone Sep 17, 2019
@danielnelson danielnelson merged commit 00d9b84 into influxdata:master Sep 24, 2019
danielnelson pushed a commit that referenced this pull request Sep 24, 2019
@sbyx @danielnelson
Fix path handling issues in cisco_telemetry_gnmi (#6403)
932597f 
- Avoid crashing when a field has no value or one of deprecated type
- Emit measurement names correctly for replies with empty origin
- Skip paths with empty names instead of adding a '/'

(cherry picked from commit 00d9b84)
bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
@sbyx @bitcharmer
Fix path handling issues in cisco_telemetry_gnmi (influxdata#6403)
e1741fb 
- Avoid crashing when a field has no value or one of deprecated type
- Emit measurement names correctly for replies with empty origin
- Skip paths with empty names instead of adding a '/'
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
@sbyx
Fix path handling issues in cisco_telemetry_gnmi (influxdata#6403)
bdc9602 
- Avoid crashing when a field has no value or one of deprecated type
- Emit measurement names correctly for replies with empty origin
- Skip paths with empty names instead of adding a '/'
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
@sbyx
Fix path handling issues in cisco_telemetry_gnmi (influxdata#6403)
b8880e4 
- Avoid crashing when a field has no value or one of deprecated type
- Emit measurement names correctly for replies with empty origin
- Skip paths with empty names instead of adding a '/'
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@sbyx @danielnelson
Fix path handling issues in cisco_telemetry_gnmi (influxdata#6403)
ae869e6 
- Avoid crashing when a field has no value or one of deprecated type
- Emit measurement names correctly for replies with empty origin
- Skip paths with empty names instead of adding a '/'

(cherry picked from commit 00d9b84)
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@sbyx @danielnelson
Fix path handling issues in cisco_telemetry_gnmi (influxdata#6403)
e367c76 
- Avoid crashing when a field has no value or one of deprecated type
- Emit measurement names correctly for replies with empty origin
- Skip paths with empty names instead of adding a '/'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix pr to fix corresponding bug
Projects
None yet
Milestone
1.12.2
Development

Successfully merging this pull request may close these issues.

Could not serialize metric: invalid name from cisco_telemetry_gnmi with gNMI interface on Arista
2 participants
@sbyx @danielnelson