Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: Telegraf CouchDB Plugin #652

Closed
wants to merge 4 commits into from
Closed

Add: Telegraf CouchDB Plugin #652

wants to merge 4 commits into from

Conversation

anands
Copy link
Contributor

@anands anands commented Feb 5, 2016

Added telegraf plugin for CouchDB, this collects data from multiple CouchDB hosts from standard couchdb endpoint _stats.

@anands
Add: Telegraf CouchDB Plugin
f224a4a 
CouchDB Plugin - Formatted Code

Minor fix for CouchDB Plugin

Formatted code fix for CouchDB Plugin

CouchDB Plugin - Changed hosts to full urls

CouchDB Plugin - Formatted Code

CouchDB Plugin - Fatal commit from local fix

CouchDB Plugin - Updated test case
@anands
Copy link
Contributor Author

anands commented Feb 5, 2016

CouchDB Plugin is passing the tests but the is some issue with config.toml, any idea @sparrc ?

Tail log from ci:

Executing './telegraf -version | grep 0.10.2-3-gf224a4a'
Telegraf - Version 0.10.2-3-gf224a4a
Executing './telegraf -config /tmp/tmp.vhj0LmBL9t/config.toml -test -input-filter cpu:mem'
2016/02/05 13:11:10 toml: line 282: parse error

'./telegraf -config /tmp/tmp.vhj0LmBL9t/config.toml -test -input-filter cpu:mem' returned 1. bash scripts/circle-test.sh returned exit code 1

@sparrc
Copy link
Contributor

sparrc commented Feb 5, 2016

The ... In hosts array is invalid toml, that's why it's getting a parse error

@sparrc
Copy link
Contributor

sparrc commented Feb 5, 2016

Could you change this to c? Using this is not a Go standard thing to do

@anands
Copy link
Contributor Author

anands commented Feb 5, 2016

Should it be URLs? as it is in influxdb input plugin?
On Feb 5, 2016 8:38 PM, "Cameron Sparr" notifications@github.com wrote:

The ... In hosts array is invalid toml, that's why it's getting a parse
error

—
Reply to this email directly or view it on GitHub
#652 (comment).

sparrc
sparrc reviewed Feb 5, 2016
View reviewed changes
plugins/inputs/couchdb/couchdb.go
`
}

func (this *CouchDB) Gather(accumulator telegraf.Accumulator) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change (this *CouchDB) to (c *CouchDB)

@sparrc
Copy link
Contributor

sparrc commented Feb 5, 2016

heh, nope, I just meant renaming this to c, as this is more in-line with Go best practices (see in-line code comment)

@anands
Copy link
Contributor Author

anands commented Feb 5, 2016

LOL. Anyways, I've changed this to c.

@sparrc
Copy link
Contributor

sparrc commented Feb 5, 2016

looks good, 👍, can you format the README like https://github.com/influxdata/telegraf/blob/master/plugins/inputs/EXAMPLE_README.md?

I'm trying to make this a template going forward (see https://github.com/influxdata/telegraf/tree/master/plugins/inputs/docker)

@anands
Copy link
Contributor Author

anands commented Feb 5, 2016

👍 updated README.md

@sparrc sparrc closed this in 9a59512 Feb 5, 2016
geodimm pushed a commit to miketonks/telegraf that referenced this pull request Mar 10, 2016
@anands @geodimm
Add: Telegraf CouchDB Plugin
042e2d1 
CouchDB Plugin - Formatted Code

closes influxdata#652

Minor fix for CouchDB Plugin

Formatted code fix for CouchDB Plugin

CouchDB Plugin - Changed hosts to full urls

CouchDB Plugin - Formatted Code

CouchDB Plugin - Fatal commit from local fix

CouchDB Plugin - Updated test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anands @sparrc