SQL Server - SQL Requests - added s.[login_name] #8351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s.[login_name] tracks SQL and NT users, while [nt_user_name] tracks only NT users.
sjwang90
added
area/sqlserver
feature request
|
@Trovalo sorry missed this, yes can you add it for the Azure ones too looks good otherwise. |
denzilribeiro
approved these changes
Jan 25, 2021
|
Looks like this PR has been forgotten for quite some time. |
|
@sspaink can you have a look at this and eventually merge it? |
sspaink
approved these changes
May 14, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s.[login_name] tracks SQL and NT users, while [nt_user_name] tracks only NT users.
Required for all PRs:
Enchantment, as of now the username is not gathered if the request comes from a SQL login, as nt_user_name tracks only NT users.
login_name tracks both SQL and NT users.
@denzilribeiro do you want me to add this also for Azure queries?