Feat: SQL Server - sqlServerRequestsV2- added s.[login_name]

[princebansal]

Required for all PRs:

• Updated associated README.md.
• Wrote appropriate unit tests.
• Pull request title or commits are in conventional commit format

This PR is an extension to #8351. Currently sqlServerRequestsV2 in sqlqueriesV2.go doesn't give SQL login name and only nt_user_name.
resolves #
This PR will add s.login_name in the output which will be helpful in logging the SQL server login name.

[telegraf-tiger]

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

[princebansal]

!signed-cla

[princebansal]

@denzilribeiro @sspaink Can you have a look at this and merge it? Need this flag urgently for our use case.

[sspaink]

Can you rebase your pull request with master? The CI is out of date and we are now using Go 1.17. The PR itself looks good, thanks for the contribution.

[princebansal]

@sspaink Thanks for the quick revert and approval. I have rebased the branch with master. Can we go ahead with the merge?
Also after merge, how will the release work? Is there a way I can use the latest build with these changes right away, or will I have to wait for the next release cycle?

[sspaink]

@princebansal before it can be merged it will need to be reviewed by another member of the core Telegraf team, I've labeled the pr with ready for final review so it will be reviewed soon. The telegraf-tiger bot just posted the artifacts containing your fix that you can use immediately so you don't have to wait for the next release cycle. Once it is merged into master there are also nightly artifacts built that you can begin using (you can find those here: https://github.com/influxdata/telegraf/blob/master/docs/NIGHTLIES.md).

[sspaink]

The Semantic Pull Request is failing because the commit in the pr doesn't abide to the conventional commit message. Can you amend the commit message to contain feat: as well? Thanks!

[princebansal]

@sspaink Thanks again for the update. I have amended the commit message to the correct format.
Regarding the release:
I am actually using the base docker image of telegraf for my use case. Will the nightly docker image also be published upon the merge in master?
Also if none of this works, when is next release being planned?

Thanks!

[telegraf-tiger]

📦 Looks like new artifacts were built from this PR.

Expand this list to get them here! 🐯

Artifact URLs

DEB	RPM	TAR GZ	ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	freebsd_amd64.tar.gz	windows_i386.zip
armel.deb	armv6hl.rpm	freebsd_armv7.tar.gz
armhf.deb	i386.rpm	freebsd_i386.tar.gz
i386.deb	ppc64le.rpm	linux_amd64.tar.gz
mips.deb	s390x.rpm	linux_arm64.tar.gz
mipsel.deb	x86_64.rpm	linux_armel.tar.gz
ppc64el.deb		linux_armhf.tar.gz
s390x.deb		linux_i386.tar.gz
		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_s390x.tar.gz
		static_linux_amd64.tar.gz

[princebansal]

@Hipska Can you please review this?

[Hipska]

I cannot approve this PR since the README states this:

Version 2 (query_version=2): Being deprecated, All future development will be under configuration option database_type.

So please make updates to the specific database type instead of version2.

[princebansal]

@Hipska Thanks a lot for that pointer. I saw that by specifying database_type="AzureSQLDB" in telegraf-conf.conf, I was able to get login_name since login_name is already included in https://github.com/influxdata/telegraf/blob/master/plugins/inputs/sqlserver/azuresqlqueries.go.

I think we can close this PR. :)