Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GetLocalHost testutil function for mac users (boot2docker) #85

Merged
merged 1 commit into from
Aug 4, 2015

Conversation

sparrc
Copy link
Contributor

@sparrc sparrc commented Aug 3, 2015

Based on google hangout with Marcos Nils

@sparrc
Copy link
Contributor Author

sparrc commented Aug 3, 2015

PS: ignore the circleci job for now, it's not ready and I've disabled for the time being.

@sparrc
Copy link
Contributor Author

sparrc commented Aug 3, 2015

@marcosnils @toddboom


var localhost = "localhost"

func GetLocalHost() string {
if dockerHostVar := os.Getenv("DOCKER_HOST"); dockerHostVar != "" {
return dockerHostVar
u, err := url.Parse(dockerHostVar)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs indentation.

@marcosnils
Copy link
Contributor

@sparrc some minor indentation is needed. Besides that LGTM 👍

@toddboom
Copy link
Contributor

toddboom commented Aug 4, 2015

@sparrc yep - looks good to me as well! +:100:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants