inputs.ping: Allow interface to be configured with both name and IP address in native mode #8770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support both name and IP
![telegraf-tiger[bot]](https://avatars.githubusercontent.com/in/94907?s=60&v=4){kind=small}
ssoroka
approved these changes
Jan 28, 2021
ssoroka
pushed a commit
that referenced
this pull request
Jan 28, 2021
Support both name and IP (cherry picked from commit 244178e)
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Support both name and IP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6642 and Fixes #8767
This pull request adds support to set the interface in native mode using either the name or IP address. Originally only the IP address was supported. Readme is already up-to-date because it stated this was supported, but as identified in #6642 it was not.
The pull request #8679 did cause a regression relating to this were the interface could no longer be set by IP address, this is now fixed as well.