Use go-ping for "native" execution in Ping plugin #8679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![telegraf-tiger[bot]](https://avatars.githubusercontent.com/in/94907?s=60&v=4){kind=small}
ivorybilled
approved these changes
Jan 12, 2021
ssoroka
reviewed
Jan 13, 2021
|
!signed-cla |
srebhan
reviewed
Jan 21, 2021
srebhan
reviewed
Jan 21, 2021
srebhan
reviewed
Jan 21, 2021
srebhan
requested changes
Jan 21, 2021
srebhan
added
area/ping
feat
ssoroka
suggested changes
Jan 26, 2021
added 6 commits
January 26, 2021 14:50
Removed dns failure check, 3rd parties libary responsibility
Update tests
ssoroka
approved these changes
Jan 26, 2021
|
This pull request introduces 1 alert when merging 22af2ef into d41569c - view on LGTM.com new alerts:
|
|
I just tried this nightly build, now when using native and i ping a IP which permanently down . i get no errors in the debug logs for telegraf, and i have uploaded a screenshot of the influxdb ping content. Running on windows 2016 |
|
He did in #8704 |
ssoroka
pushed a commit
that referenced
this pull request
Jan 27, 2021
(cherry picked from commit c237989)
This was referenced Jan 27, 2021
This was referenced Jan 28, 2021
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
* Use go-ping for "native" execution in Ping plugin * Check for ipv6 and deadline out of go func * ensure dns failure * Move interval and timeout calc to init Removed dns failure check, 3rd parties libary responsibility * Rename timeout to avoid conflict * Move native ping to interface Update tests * Check for zero length
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
Updated the
input plugin Pingto use the package go-ping when using "native" in the configuration. I believe this improves code readability without breaking any backwards compatible functionality. I was having 100% packet loss with the original implementation that I couldn't resolve even after providing the correct permissions as specified in the README, using the new implementation solved this problem for me. Moving all the implementation details to go-ping should help with future maintenance of this plugin.This might help address the following issues: