Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List series should return as a single series #358

Closed
pauldix opened this issue Mar 23, 2014 · 1 comment
Closed

List series should return as a single series #358

pauldix opened this issue Mar 23, 2014 · 1 comment
Milestone

Comments

@pauldix
Copy link
Member

pauldix commented Mar 23, 2014

List series currently returns an array of time series objects. Instead, it should return something like:

[{
  "name":"series",
  "columns":["name"],
  "points": [
    ["series_A"],
    ["other_series"]
  ]
}]
@jvshahid
Copy link
Contributor

This will be closed once #689 is merged into master.

@jvshahid jvshahid modified the milestones: 0.7.4, Next release Jul 10, 2014
pauldix added a commit that referenced this issue Jul 10, 2014
Fixes #414. All series metadata, that is which series exist, what columns they have, and what the ids of those columns has been moved into Raft.

This means that list series queries are now very fast since they operate on an in memory data structure. It also means that writes no longer have to do gets agains the storage engine to resolve what a column's id is.

Fixes #358. List series now returns as a single series with a `name` column.

This fix has the potential to slow things down in scenarios that people suddenly write many thousands of new series in less than a second. That's because the definition of new series now needs to go through the raft leader and get consensus. I think it's unlikely that it'll be a problem, but we'll need to do extensive testing.

Finally, there is the issue that the Raft snapshots can potentially become big. We should do testing with setups that have millions of series to ensure that performance and startup time remain good.
@jvshahid jvshahid modified the milestones: 0.8.0, 0.7.4 Jul 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants