Move series metadata to raft #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 25, 2014
| @@ -329,6 +333,15 @@ func (self *ClusterConfiguration) DropDatabase(name string) error { | |||
| defer self.usersLock.Unlock() | |||
|
|
|||
| delete(self.dbUsers, name) | |||
|
|
|||
| fields := self.MetaStore.GetFieldsForDatabase(name) | |||
| self.MetaStore.DropDatabase(name) | |||
There was a problem hiding this comment.
I think there's a potential of a race condition here. We should combine these two functions into one DropAndGet() so we make sure that the fields don't change between the two calls. Same for DropSeries() on line 1056
Fixes #414. All series metadata, that is which series exist, what columns they have, and what the ids of those columns has been moved into Raft. This means that list series queries are now very fast since they operate on an in memory data structure. It also means that writes no longer have to do gets agains the storage engine to resolve what a column's id is. Fixes #358. List series now returns as a single series with a `name` column. This fix has the potential to slow things down in scenarios that people suddenly write many thousands of new series in less than a second. That's because the definition of new series now needs to go through the raft leader and get consensus. I think it's unlikely that it'll be a problem, but we'll need to do extensive testing. Finally, there is the issue that the Raft snapshots can potentially become big. We should do testing with setups that have millions of series to ensure that performance and startup time remain good.
jvshahid
added a commit
that referenced
this pull request
Jul 10, 2014
…a-to-raft Move series metadata to raft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.