Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving the EA filter query to request URL instead of building it on t… #49

Closed
wants to merge 2 commits into from

Conversation

chinmayb
Copy link
Contributor

…he payload body

* Currently the EA filters are passed as api payload, this is creating
  problem when the obj is empty and ea is requested in GET call. Hence
  moving it as URL parameter.

  `objJSON = append(append(objJSON[:len(objJSON)-1], byte(',')), eaSearchJSON[1:]...)`
  The above objJSON fails to get unmarshalled when objJSON is not having any payload apart from easearch.  Empty check becomes tedious for the generic obj.  

* Add Get A record call

…he payload body

    * Currently the EA filters are passed as api payload, this is creating
      problem when the obj is empty and ea is requested in GET call. Hence
      moving it as URL parameter.

      `objJSON = append(append(objJSON[:len(objJSON)-1], byte(',')), eaSearchJSON[1:]...)`

    * Add Get A record call
@chinmayb chinmayb closed this Apr 2, 2018
@chinmayb chinmayb deleted the dev branch April 2, 2018 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant