Request #4775 ids-icons-standard.sketch #459
Conversation
Newly added Approve and Approve-filled icon.
|
@laurensteiger - reminder for now we still need to support the old (subtle/soho/classic theme). So can you put a "older" matching variation of the two new icons in the sketch/theme-soho/ids-icons-standard.sketch as well? Also something else strange is i see the icon there but it didn't show up in either the standard or extended section. Maybe some classification or something else is missing compared to the other icons? (this could be the first problem as well but thought i mentioned so you can double check) |
|
@tmcconechy I was not given a soho icon. I put the icons in the extended section, was it supposed to go in standard? |
|
No it just isn't showing up in the code/site when i run the generator. I'm not 100% sure what is wrong. But it could be that we don't have a soho icon to go with it? I think we need one or it wont work and it wont appear in the classic theme. Couldn't we just create equal ones for soho thats similar? |
Newly added Approve and Approve-filled icon.
Explain the details for making this change. What existing problem does the pull request solve?
Request #4775: