-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lookup multiselect - multi page selections with server side paging #954
Comments
Can you check the steps against master branch (latest). When i tried this out and follow the video i dont see this issue. |
We can reproduce this issue by using below steps. 1 . Go to ids-enterprise-ng-demo/lookup Check previous record get replaced by new one. |
ok i see this now. Updated the steps. What is interesting is this works ok on this example https://master-enterprise.demo.design.infor.com/components/lookup/example-multiselect-paging-serverside.html So assuming something is wrong in the setup of this example. Will try and find some time for this. |
Hi Tim, We have added below code in "sohoxi.js" and it looks working fine. Please review the below code and test the functionality.
|
Can you highlight what you changed here? Im having difficulty merging this because it looks like you edited the processed Javascript. The real code looks like this https://github.com/infor-design/enterprise/blob/master/src/components/lookup/lookup.js#L709 (for example var replaced for const ect). Would you like to do a pull request with this change? https://github.com/infor-design/enterprise/blob/master/docs/CONTRIBUTING.md#submitting-pull-requests |
Hi Tim, We have added the "Else" condition for line no :- https://github.com/infor-design/enterprise/blob/master/src/components/lookup/lookup.js#L726 |
Ok, still confused. https://github.com/infor-design/enterprise/blob/master/src/components/lookup/lookup.js#L726 oesnt even have an else. Its like comparing two different code bases....Can you take this actual latest code and add the changes (as test not a screen shot) and paste it in a comment here. Then i can test this out and PR for you
|
HI, Attached the code changes file js (Changes Line No :- 758 to 790). |
HI Tim, I have done the pull request - https://github.com/kvchaudhari/enterprise_latest Changes in :- https://github.com/kvchaudhari/enterprise_latest/blob/master/src/components/lookup/lookup.js |
OK great! All you have to do now is make a pull request to move it over to our repo. Although with this i can probably do the diff if your having issues (i cant do that step for you since its in your repo but there should be a button) |
Pushed this infor-design/enterprise#4703 and tested and it looks good. Waiting for more reviews |
Hi Tim, We observed same issue with 4.36.1 SoHo library. Do I need to report separate issue or can we reopen this issue? Regards, |
@kvchaudhari had provided the fix - do you have any suggestions here? I tested the first steps on the issue and your right this isnt fixed. Did we missing something merging the fix? We should reopen i guess. |
HI @tmcconechy , Only getting issue with - "Products (Multi Select Stored as Object) with existing value" - Note :- For multiselect lookup, if any id is default selected and which is not present in the grid data then after selection new id, this id got replaced. Regards, |
I'm a but confused about this issue at this stage. Also the fact that @kvchaudhari says its working. But as far as i can see on master and 4.37. Its working with these steps. But i do recall seeing it not work in the past and see it working now. These are the steps im using to verify:
I looked at what you said on "Products (Multi Select Stored as Object) with existing value" but this one will not work because allowSelectAcrossPages is not set. My suggestion is we close this. If further issues please make a new issue with the more precise steps / expected results ect. As this one has too much history now to follow. Sorry to do that but having a really hard time with this one to follow and it looks ok as i expect; so i think we need to make a new issue. |
Describe the bug
We found one issue in ids-enterprise-ng-demo/lookup . Please follow below steps to reproduce issue.
To Reproduce
Steps to reproduce the behavior:
1 . Go to http://localhost:4200/ids-enterprise-ng-demo/lookup
Expected behavior
Expected two selected records.
Version
Screenshots
If applicable, add screenshots to help explain y
MultiselectLookup.zip
our problem.
Platform
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: