-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
991 - Add Datagrid editing #1057
Conversation
…-datagrid-editing
…-datagrid-editing
…-datagrid-editing
…-datagrid-editing
…-datagrid-editing
…-datagrid-editing
…-datagrid-editing
Nice! couple things I found by following the pr test instructions Selecting rows with description 106 & 108 and then clicking delete button, deletes rows with description 106 & 109. Clearing an editable description then pressing Enter doesn't show required error, clearing and then focusing out with mouse click does trigger the error though |
thanks @jdilag90 fixed those 2.... |
Looks nice, found few as: http://localhost:4300/ids-data-grid/editable.html
|
@deep7102 and all. I think i got everything here please check again. |
Everything looked good functionality-wise, but something is out of sorts in the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🍌
Explain the details for making this change. What existing problem does the pull request solve?
This PR adds the ability to edit input cells and checkbox editors in the datagrid. As well as a lot of editing related features. Like addRow, clearRow ect. Validation and dirty tracking
Related github/jira issue (required):
Fixes #991
Fixes #1057
Steps necessary to review your pull request (required):
Misc
Basics
Validation/Dirty
$('ids-data-grid').dirtyCells
to get an outputButtons
Keyboard
Included in this Pull Request: