Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

991 - Add Datagrid editing #1057

Merged
merged 24 commits into from
Dec 27, 2022
Merged

991 - Add Datagrid editing #1057

merged 24 commits into from
Dec 27, 2022

Conversation

tmcconechy
Copy link
Member

@tmcconechy tmcconechy commented Dec 20, 2022

Explain the details for making this change. What existing problem does the pull request solve?

This PR adds the ability to edit input cells and checkbox editors in the datagrid. As well as a lot of editing related features. Like addRow, clearRow ect. Validation and dirty tracking

Related github/jira issue (required):
Fixes #991
Fixes #1057

Steps necessary to review your pull request (required):
Misc

  • http://localhost:4300/ids-alert/example.html alerts can hover tooltips now
  • card context menus dont break out of the card
  • checkbox can not have animation
  • delimeter misspelled and fixed
  • menu can be toggleable. Try row heights
  • review PR/Docs

Basics

Validation/Dirty

  • clear the description and hit enter and an error will show
  • try and reset the error
  • same for dirty indicator
  • when some cells are dirty type $('ids-data-grid').dirtyCells to get an output

Buttons

  • try the add button to see addRow work
  • try the delete button to see removeRow work (works on first selected row)
  • try the clear button to see clear work (works on first selected row)

Keyboard

  • ENTER] Start editing
  • [ENTER] Finish editing and start editing the same cell in next row if editNextOnEnterPress is on
  • [SHIFT] + [ENTER] Same as above but with previous row if editNextOnEnterPress
  • [F2] Finish editing and stay in same cell
  • [CMD/CTRL] + [ENTER] Also Finish editing
  • [ESC] Reverts the value back to its original value and cancels editing
  • Start Typing any key to start edit
  • Space Bar -> works with selection and keyboard when not editing
  • [TAB] Finish editing and start editing the next cell (replaces actionable mode)
  • [SHIFT] + [TAB] Finish editing and start editing the previous cell (replaces actionable mode)

Included in this Pull Request:

  • An e2e or functional test for the bug or feature.
  • A note to the change log.

@tmcconechy tmcconechy requested a review from a team as a code owner December 20, 2022 21:26
@jdilag90
Copy link
Collaborator

Nice! couple things I found by following the pr test instructions

Selecting rows with description 106 & 108 and then clicking delete button, deletes rows with description 106 & 109.

Clearing an editable description then pressing Enter doesn't show required error, clearing and then focusing out with mouse click does trigger the error though

@tmcconechy
Copy link
Member Author

thanks @jdilag90 fixed those 2....

jdilag90
jdilag90 previously approved these changes Dec 21, 2022
@deep7102
Copy link
Contributor

deep7102 commented Dec 21, 2022

Looks nice, found few as:

http://localhost:4300/ids-data-grid/editable.html

  • clear wrong row
- make error by removing `108` from `Description` column 2nd last row
- click sort, now this error row will move to 1st row
- click on checkbox to select this first row
- click on `clear` button
- see it clear but wrong row, and it reset the sort it self
  • error cell not move with rearrange
- make error by removing `102` from `Description` column 2nd row
- drag and move `Description` column to somewhere else
- see error cell not moved along column
  • error cell color not consistent
- switch to dark or contrast theme
- make error by removing `102` from `Description` column 2nd row
- and make error by removing `108` from `Description` column 2nd last row
- click sort, now this error rows will move to top
- but it change the cell color

@tmcconechy
Copy link
Member Author

@deep7102 and all. I think i got everything here please check again.

@EdwardCoyle
Copy link
Contributor

Everything looked good functionality-wise, but something is out of sorts in the tests.

Copy link
Contributor

@deep7102 deep7102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🍌

@tmcconechy tmcconechy merged commit 7a1b0c4 into main Dec 27, 2022
@tmcconechy tmcconechy deleted the 991-datagrid-editing branch December 27, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IdsDataGrid: Add editing (isEditable) with maskOptions
5 participants