1189 - IdsTimepicker Fix formatting when day period goes first in the time format #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: (75 commits) fix menu button icon Hide menu items in IdsMasthead Revert aria-description change, ignore in tests Update snapshots/fix test conditions Fix scrollable IdsPopup-related aXe violations Add fine grain control over flip logic in IdsPopup to account for label sizes Add fine grain control over flip logic in IdsPopup to account for label sizes Fix bad spacing when IdsDatePicker popup changes axes Fix input field cutoff issue in some layouts Fix IdsPager input field size Remove unused code Remove unavailable Popup example Allow IdsPopupMenu resize to fix/unfix menu height Add changelog note for #1205 Fix lint issues Fix docs/tests Fix submenu navigation issue Normalize IdsToolbarMoreActions menu structure for light DOM, fix menu behavior Remove extra tweak Add IdsPopupMenu scrolling demo, better sharing of maxHeight property ...
* main: (63 commits) Wizard contrast test Small change in wizard test Skip problematic tests Add fix for order setting Fix import issue in examples Fix some examples that were missed on the first pass Fix virtual scroll and wizard tests Fix draggable example Fix color picker lint error Fix readme Fix lint errors Minor update to readme Update button setting Remove old grid directory Update more examples More example fixes Add more e2e tests Add align settings to grid cell items Use attributes instead classes on the host element Minor adjustment to documentation ...
tmcconechy
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the details for making this change. What existing problem does the pull request solve?
This PR adds adjustments to the time picker and
formatDatefunction to be able to format day period correctlyRelated github/jira issue (required):
Closes #1189
Steps necessary to review your pull request (required):
document.querySelector('ids-container').locale = 'ko-KR'a h:mmTime Picker - requiredexampleIncluded in this Pull Request:
- [ ] An e2e or functional test for the bug or feature.