Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IdsTimePicker: Invalid value when day period goes first in the time format #1189

Closed
andriivarhanov opened this issue Mar 16, 2023 · 2 comments · Fixed by #1254
Closed

IdsTimePicker: Invalid value when day period goes first in the time format #1189

andriivarhanov opened this issue Mar 16, 2023 · 2 comments · Fixed by #1254
Assignees
Labels
type: bug 🐛 Something isn't working [2] Velocity rating (Fibonacci)

Comments

@andriivarhanov
Copy link
Contributor

Describe the bug
Similar issue as in EP infor-design/enterprise#7116 just for the web component, the timepicker doesn't format value correctly when day period goes first in the time format

To Reproduce

  • Go to https://main.wc.design.infor.com/ids-time-picker/example.html
  • Change the locale to ko-KR in the browser's console document.querySelector('ids-container').locale = 'ko-KR'
  • Select a time, see the error,
    • Time Picker - default example showing day period after numeric time
    • Time Picker - required triggers error message

Expected behavior
The timepicker should format value correctly by the locale's time format

Additional context

@tmcconechy tmcconechy added type: bug 🐛 Something isn't working [2] Velocity rating (Fibonacci) labels Mar 16, 2023
@tmcconechy
Copy link
Member

Feel free to pick this up @andriivarhanov when you have time

@jbrcna
Copy link
Contributor

jbrcna commented Apr 27, 2023

QA Passed.
ko-KR
image

zh-Hans
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working [2] Velocity rating (Fibonacci)
Projects
No open projects
3 participants