Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1933 - Add context menu to actions button #2157

Merged
merged 12 commits into from
Apr 4, 2024
Merged

Conversation

tmcconechy
Copy link
Member

Explain the details for making this change. What existing problem does the pull request solve?

Adds a menuId and selected callback setting to datagrid columns that can be used to link a popupmenu to a column formatter.

Related github/jira issue (required):
Fixes #1933

Steps necessary to review your pull request (required):

Included in this Pull Request:

  • Some documentation for the feature.
  • A test for the bug or feature.
  • A note to the change log.

@tmcconechy tmcconechy requested a review from a team as a code owner April 2, 2024 18:42
@jdilag90
Copy link
Collaborator

jdilag90 commented Apr 3, 2024

Select a menu item from one popup multiple times.
The event is fired multiple time after each selection.
Probably just an event that needs to be unbound

image

@tmcconechy
Copy link
Member Author

@jdilag90 thanks good catch. That one should be fixed now.

jmacaluso711
jmacaluso711 previously approved these changes Apr 3, 2024
@tmcconechy tmcconechy merged commit 2b0bf8e into main Apr 4, 2024
4 checks passed
@tmcconechy tmcconechy deleted the 1933-actions-formatter branch April 4, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataGrid - Actions column formatter
3 participants