Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2207 - IdsDatePicker input value sync #2342

Merged
merged 5 commits into from
May 21, 2024
Merged

Conversation

jdilag90
Copy link
Collaborator

@jdilag90 jdilag90 commented May 20, 2024

Explain the details for making this change. What existing problem does the pull request solve?
Fixes issue where manual date inputs didn't sync with date picker value and picker popup

Related github/jira issue (required):
Closes #2207

Steps necessary to review your pull request (required):

  1. Checkout branch
  2. Go to http://localhost:4300/ids-date-picker/example.html
  3. Enter a date manually
  4. Check that $('ids-date-picker').value matches that date
  5. Open popup and check that your input date is displayed and selected

Included in this Pull Request:

  • Some documentation for the feature.
  • A test for the bug or feature.
  • A note to the change log.

@jdilag90 jdilag90 requested a review from a team as a code owner May 20, 2024 15:32
tmcconechy
tmcconechy previously approved these changes May 21, 2024
@tmcconechy tmcconechy merged commit 05ce8b2 into main May 21, 2024
1 of 2 checks passed
@tmcconechy tmcconechy deleted the 2207-datepicker-input-value branch May 21, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IdsDatePicker: Changing textbox manually does not change the value passed by the component
4 participants