Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2048 - IdsAppMenu selected item background color #2373

Merged
merged 3 commits into from
May 29, 2024

Conversation

jmacaluso711
Copy link
Contributor

Explain the details for making this change. What existing problem does the pull request solve?
This PR adds a fix for the background color of the selected item in an app menu.

Related github/jira issue (required):
closes #2048

Steps necessary to review your pull request (required):

Included in this Pull Request:
- [ ] Some documentation for the feature.
- [ ] A test for the bug or feature.

  • A note to the change log.

@jmacaluso711 jmacaluso711 requested a review from a team as a code owner May 24, 2024 15:03
* main: (21 commits)
  Move table to personalize
  Collapse rows by default
  Enable sorting
  Add unique id to each object
  Add component name to object
  Add filters
  Fix lint error
  Add token type to table
  Update script to read from node_modules
  Update snapshots
  Fix typo in token scripts
  Add token scripts to pacakge.json
  Add suppress tooltip option to color formatter
  Add semanticCoreTheme as depenency
  Clean up theme json script
  Add dropdown to switch themes
  Test in datagrid
  Write files to themeData folder
  Fix inherited tokenValue bug
  Building token object
  ...
Copy link
Collaborator

@andrivarhanov andrivarhanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but tests failed for some reason, let's see what happens after re-run

@tmcconechy tmcconechy merged commit 987761e into main May 29, 2024
4 checks passed
@tmcconechy tmcconechy deleted the 2048-active-main-menu branch May 29, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IdsAppMenu/IdsModuleNav: Highlighting the Active Main Menu
3 participants