-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
132 - Add dropdown component #346
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good! I found a couple of minor usability nitpicks that might be better suited for a Phase 2, but figured should note them here:
- Per the current behavior of the No Search dropdown, the typeahead feature should allow selection of the next matching item matching the key phrase typed. For example, goto https://main-enterprise.demo.design.infor.com/components/dropdown/example-index.html and:
- Focus the dropdown without opening it (via keyboard or click the label)
- Tap "t" to select "two"
- Tap "t" again to select "three"
- Try tapping multiple letters to half-spell something like "fo" or "fi".
- In all cases the typeahead works without the list opening.
- This should also work when the list is open.
- When using the keyboard arrows to open the menu, there's a slight jump in the list scrolling that isn't there when using enter or clicking
- Really minor but if the Dropdown's not using an input field (noSearch mode) it should probably use the pointer mouse cursor instead of the text cursor.
I'm willing to approve in any case 👍
ok, im going to take a look at those. The cursor was a pointer as i added an option to ids-input for cursor but i think maybe i merged it out. I'll take a quick pass and update after. |
0854744
@EdwardCoyle fixed all three issues mentioned |
Merging as this was previously approved |
Explain the details for making this change. What existing problem does the pull request solve?
This PR mainly adds the dropdown component and some related fixes needed to support it. The fixes include:
Related github/jira issue (required):
Fixes #132
Steps necessary to review your pull request (required):
Included in this Pull Request: