Add timeline fixes

infor-design · Apr 10, 2024 · 152c112 · 152c112
1 parent dfb7581
commit 152c112
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 11 deletions.
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -1,5 +1,12 @@
 # What's New with Enterprise
 
+## v4.94.1
+
+## v4.94.1 Fixes
+
+- `[Homepage]` Fixed bug that caused errors on resize when no widgets. ([#8611](https://github.com/infor-design/enterprise/issues/8611))
+- `[Timeline]` Added fix to timeline layout. ([#8586](https://github.com/infor-design/enterprise/issues/8586))
+
 ## v4.94.0
 
 ## v4.94.0 Features

diff --git a/src/components/homepage/homepage.js b/src/components/homepage/homepage.js
@@ -741,8 +741,10 @@ Homepage.prototype = {
       let rowsUsed = 0;
       let abort = false;
       let calcHeight = card.outerHeight();
-      calcHeight += parseInt(window.getComputedStyle(card[0]).getPropertyValue('margin-top'), 10);
-      calcHeight += parseInt(window.getComputedStyle(card[0]).getPropertyValue('margin-bottom'), 10);
+      if (card[0]) {
+        calcHeight += parseInt(window.getComputedStyle(card[0]).getPropertyValue('margin-top'), 10);
+        calcHeight += parseInt(window.getComputedStyle(card[0]).getPropertyValue('margin-bottom'), 10);
+      }
 
       for (let rows = 0; rows < this.rowsAndCols.length && !abort; rows++) {
         rowsUsed++;

diff --git a/src/components/timeline/_timeline-new.scss b/src/components/timeline/_timeline-new.scss
@@ -28,14 +28,6 @@
   top: -0.12em;
 }
 
-@media (min-width: 767px) {
-  .timeline {
-    &::before {
-      left: 12.7em;
-    }
-  }
-}
-
 html[dir='rtl'] {
   .indicator-container {
     right: -2px;

diff --git a/src/components/timeline/_timeline.scss b/src/components/timeline/_timeline.scss
@@ -15,7 +15,7 @@
     position: absolute;
     top: 0;
     width: 3px;
-    height: 80%;
+    height: calc(80% + 5px);
   }
 
   .indicator {