Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch: Disabled Switch On Status Not Easily Discernible #4341

Closed
hemantg05 opened this issue Sep 3, 2020 · 9 comments
Closed

Switch: Disabled Switch On Status Not Easily Discernible #4341

hemantg05 opened this issue Sep 3, 2020 · 9 comments
Assignees
Labels
focus: uplift theme Items related to completion the Uplift theme type: bug 🐛 [3] Velocity rating (Fibonacci)

Comments

@hemantg05
Copy link

Disabled ON Switch is not easily discernible.

Describe the bug
User can not easily discern whether the switch is ON or OFF.

Expected behavior
Disabled ON Switch is should be easily discernible.

Screenshots
Disabled-ON-Switch

Additional context
cc @karinthulin, PIM

@tmcconechy tmcconechy added [3] Velocity rating (Fibonacci) focus: uplift theme Items related to completion the Uplift theme design Needs input from IDS Design Team type: bug 🐛 labels Sep 3, 2020
@tmcconechy
Copy link
Member

I think this is a valid concern. I looked at a few other examples and most of them include the color in the disabled state for example

Screen Shot 2020-09-03 at 10 07 20 AM

Screen Shot 2020-09-03 at 10 07 27 AM

In addition because of accessibility we should really incorporate on/off text in the state as well.

Can design take a look @inforandy

@karinthulin
Copy link

@tmcconechy this is an issue in PIM application. Can this be addressed?

@tmcconechy tmcconechy added this to To do in Enterprise 4.50.x (Mar 2021) Sprint via automation Mar 5, 2021
@tmcconechy
Copy link
Member

tmcconechy commented Mar 5, 2021

Sure, taking a look this sprint. But if you need a quick fix. We'll just change the color of disabled to be less. Not change the design to add on/off text. That way we can get this done much quicker without a design change.

i.e. when on and disabled still show the blue color to indicate on but in a dimmer blue.

@tmcconechy
Copy link
Member

See previous comment. We are just changing the disabled state to have a color so you can easier tell on / off.
Also please fix this in both this repo and https://github.com/infor-design/enterprise-wc as its in both. So two PR's

@rob2d
Copy link
Contributor

rob2d commented Mar 31, 2021

@tmcconechy tried to make the most minimal change possible, seems would be easier to see with the bg bar than with the circle outline.

Would this work?
image

@rob2d
Copy link
Contributor

rob2d commented Apr 1, 2021

should have re-read the issue before working on that -- adjusting the disabled on state now.

@rob2d
Copy link
Contributor

rob2d commented Apr 1, 2021

@tmcconechy @hemantg05

For main theme, does this seem it may be differentiated enough?
(kept a graphite-colored outline as having a perfectly azure circle even if lighter was a bit confusing)

edit: other variants

image
image
image
image

rob2d added a commit that referenced this issue Apr 1, 2021
@tmcconechy
Copy link
Member

tmcconechy commented Apr 1, 2021

Did you see the color options here https://master-enterprise.demo.design.infor.com/components/colors/example-index.html was thinking Azure 01 - so its quite light? Is it that already if not could go down one color in the sequence?

@tmcconechy tmcconechy removed the design Needs input from IDS Design Team label Apr 1, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.50.x (Mar 2021) Sprint via automation Apr 2, 2021
@tmcconechy tmcconechy moved this from To do to Ready for QA (master) in Enterprise 4.50.x (Mar 2021) Sprint Apr 2, 2021
@jbrcna
Copy link
Contributor

jbrcna commented Apr 5, 2021

@jbrcna jbrcna moved this from Ready for QA (master) to Done in Enterprise 4.50.x (Mar 2021) Sprint Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: uplift theme Items related to completion the Uplift theme type: bug 🐛 [3] Velocity rating (Fibonacci)
Projects
No open projects
Development

No branches or pull requests

5 participants