Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BreadCrumb: Unintentional Breakage on css only version #4501

Closed
tmcconechy opened this issue Oct 16, 2020 · 1 comment · Fixed by #4502
Closed

BreadCrumb: Unintentional Breakage on css only version #4501

tmcconechy opened this issue Oct 16, 2020 · 1 comment · Fixed by #4502
Assignees
Labels
type: regression bug ↩️ [2] Velocity rating (Fibonacci)

Comments

@tmcconechy
Copy link
Member

Describe the bug
If you leave the bread-crumb-list class off then dont invoke the breadcrumb, this doesnt work anymore. It just shows it as a list. Will adjust to make it more backwards compatible

To Reproduce
Steps to reproduce the behavior:

  1. Make a test page with
<div class="row">
  <div class="twelve columns">
    <nav class="breadcrumb" data-init="false">
      <ol aria-label="breadcrumb">
        <li>
          <a href="#" id="home" class="hyperlink hide-focus">Home</a>
        </li>
        <li>
          <a href="#" id="second-item" class="hyperlink hide-focus">Second Item</a>
        </li>
        <li>
          <a href="#" id="third-item" class="hyperlink hide-focus">Third Item</a>
        </li>
        <li class="current">Fourth Item <span class="audible">Current</span></li>
      </ol>
    </nav>
  </div>
</div>
  1. load it up in the browser
  2. See error -> does not look like a bread crumb

Expected behavior
Still works as before with css only

Version

  • ids-enterprise: [e.g. v4.33]

Additional context
May require a patch to 8.0.0

@tmcconechy tmcconechy self-assigned this Oct 16, 2020
@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) type: regression bug ↩️ labels Oct 16, 2020
@tmcconechy tmcconechy added this to To do in Enterprise 4.34.x (Oct 2020) Sprint via automation Oct 16, 2020
@tmcconechy tmcconechy moved this from To do to Pending Review in Enterprise 4.34.x (Oct 2020) Sprint Oct 16, 2020
tmcconechy added a commit that referenced this issue Oct 16, 2020
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.34.x (Oct 2020) Sprint Oct 22, 2020
@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.34.x (Oct 2020) Sprint Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: regression bug ↩️ [2] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants