Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Menu: If search finds children then the parent is not expanded #4592

Closed
Milan1983 opened this issue Nov 10, 2020 · 7 comments · Fixed by #4710
Closed

Application Menu: If search finds children then the parent is not expanded #4592

Milan1983 opened this issue Nov 10, 2020 · 7 comments · Fixed by #4710
Assignees
Labels
type: bug 🐛 [2] Velocity rating (Fibonacci)

Comments

@Milan1983
Copy link
Contributor

Describe the bug
In some search conditions the results is not expanding.

To Reproduce
Steps to reproduce the behavior:

Expected behavior
Results should be expanded

Version
V 4.34.0

Platform

  • Chrome Version 86.0.4240.183

I think the problem it is in done method.

@tmcconechy tmcconechy changed the title Expand items with some specific condition is not working - Application Menu Application Menu: Expand items with some specific condition is not working Nov 10, 2020
@tmcconechy tmcconechy changed the title Application Menu: Expand items with some specific condition is not working Application Menu: If search finds children then the parent is not expanded Nov 10, 2020
@tmcconechy tmcconechy added this to To do in Enterprise 4.36.x (Dec 2020) Sprint via automation Nov 10, 2020
@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) type: bug 🐛 labels Nov 10, 2020
@tmcconechy
Copy link
Member

Any other specifics you have on it being in the done method would be helpful to speed up a fix?

@Milan1983
Copy link
Contributor Author

Unfortunately not @tmcconechy .
Also I realized when you search non-existed items,show all results,and I think is wrong.

@tmcconechy
Copy link
Member

ok we will have a look

@Milan1983
Copy link
Contributor Author

Thank you @tmcconechy

@Milan1983
Copy link
Contributor Author

Milan1983 commented Dec 7, 2020

Is it possible to investigate this situation, please.

https://design.infor.com/code/ids-enterprise/latest/demo/components/applicationmenu/example-filterable?theme=uplift&variant=light

search for 'zzzz'
Results : Everything and is possible expand
step 1)
My Account
Bookmarks
History
Homepages
My Roles
step 2) if you clicked for example on My Account,it is possible to expand
My Account
Notifications
Administrator
User Settings
Help
Bookmarks
History
Homepages
My Roles

Expected:
step 1)
My Account
Bookmarks
History
Homepages
My Roles
step 2) Not possible to expand

I think shows everything and works in an 'unfiltered' mode basically.

@tmcconechy
Copy link
Member

think simpler put - searching for zzzz is returning all results and not filtering to nothing as i would expect. I think this should be fixed as well on this issue

@jbrcna
Copy link
Contributor

jbrcna commented Dec 28, 2020

QA Passed
v4.36.0-dev
In the app menu searchfield, type "#3". After filtering completes, the results should include: "Role #1 Task #3", "Role #2 Task #3", and "Role #3".
image

Clear the searchfield and type "zzzzz". After filtering completes, no items should be present in the filter results.
image

@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.36.x (Dec 2020) Sprint Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants