-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DatePicker: Incorrect validation message for invalid value scenario #4888
Comments
I dont think "Date Time" makes sense. A date can have time. Can we think of a better description all together? What about "Invalid Value" or "Invalid Date or Time"? Technically this isnt wrong. Its an invalid date |
Let's go for "Invalid Date or Time", our QA accepts that :) |
Ok we'll have to check there is a time and then show that message (or the previous). Seems minor but makes sense |
@danielortiz1982 so what we decided on this is to change the message but only if the date format has time associated with it http://localhost:4000/components/datepicker/example-timeformat.html When you top a bad date tab out of the field it should now say "Invalid Date or Time" if there is a time involved. The validation code is here for the dates https://github.com/infor-design/enterprise/blob/master/src/components/validation/validation.js#L109 To add a new translation string you just add an entry into th en-US locale file https://github.com/infor-design/enterprise/blob/master/src/components/locale/cultures/en-US.js#L64 |
Thanks for this update @tmcconechy |
…owTime instead of field[0].classList
the issue is now resolved. v4.39.0-dev. thank you |
Describe the bug
When using date picker with time, the validation message is not correct for invalid value scenario.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The validation message should be Invalid Date Time instead of Invalid Date because I am using date picker with time
Version
Screenshots
Platform
Additional context
N.A.
The text was updated successfully, but these errors were encountered: