Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal: Enter key does not trigger the Primary Button #5198

Closed
brianpettit opened this issue May 17, 2021 · 1 comment · Fixed by #5418
Closed

Modal: Enter key does not trigger the Primary Button #5198

brianpettit opened this issue May 17, 2021 · 1 comment · Fixed by #5418
Assignees
@yohannahbautista
Labels
team: OAD OAD Team Issues and Enhancements type: regression bug ↩️ [2] Velocity rating (Fibonacci)
Projects
Enterprise 4.54.x (July 2021) Sprint

Comments

@brianpettit
Copy link

brianpettit commented May 17, 2021 •
edited by tmcconechy

Describe the bug

When using modal its expected that enter will submit the form. Some code ttps://github.com/infor-design/enterprise/blob/main/src/components/modal/modal.js#L976 is trying to do it but seems a bit off.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://main-enterprise.demo.design.infor.com/components/modal/example-index.html
  2. Fill in the problem field (now all fields are valid)
  3. Hit enter
  4. See error

Expected behavior
Enter should submit the modal when in an input

Version

  • ids-enterprise: v4.51.0

Platform

  • Chrome/ Any

Additional context
There is code thats "trying" to do it https://github.com/infor-design/enterprise/blob/main/src/components/modal/modal.js#L976 but in my tests its not working when you are in input elements and im not sure why that's the case
@tmcconechy tmcconechy changed the title On modal, Enter key does not trigger Primary Button on form. Modal: Enter key does not trigger the Primary Button May 17, 2021
@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) type: bug 🐛 labels May 17, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.54.x (July 2021) Sprint via automation May 17, 2021
@ghost ghost added team: OAD OAD Team Issues and Enhancements type: regression bug ↩️ and removed type: bug 🐛 labels May 26, 2021
@yohannahbautista yohannahbautista mentioned this issue Jul 13, 2021
Merged
1 task
@tmcconechy tmcconechy moved this from To do to In progress in Enterprise 4.54.x (July 2021) Sprint Jul 13, 2021
@tmcconechy tmcconechy moved this from In progress to Pending Review in Enterprise 4.54.x (July 2021) Sprint Jul 19, 2021
@tmcconechy tmcconechy moved this from Pending Review to Failed QA (beta) in Enterprise 4.54.x (July 2021) Sprint Jul 19, 2021
@tmcconechy tmcconechy moved this from Failed QA (beta) to Ready for QA (beta) in Enterprise 4.54.x (July 2021) Sprint Jul 21, 2021
@jbrcna
Copy link
Contributor

jbrcna commented Jul 22, 2021

this is now working as expected. moving this ticket to Done
v4.54.0-dev
verified in https://main-enterprise.demo.design.infor.com/components/modal/example-index.html

@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.54.x (July 2021) Sprint Jul 22, 2021
@tmcconechy tmcconechy mentioned this issue Oct 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yohannahbautista yohannahbautista

Labels
team: OAD OAD Team Issues and Enhancements type: regression bug ↩️ [2] Velocity rating (Fibonacci)
Projects
No open projects
Enterprise 4.54.x (July 2021) Sprint
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

5198 - Modal: Enter key in input will trigger primary button infor-design/enterprise
4 participants
@tmcconechy @jbrcna @brianpettit @yohannahbautista