Modal: Enter key closes dialog unexpectedly

[anhallbe]

Describe the bug
When in a dialog, pressing the "Enter" key when focusing a field that doesn't handle the event (keydown enter) will cause the dialog to be closed.

I'm not sure if this is a bug or feature, but it's a new (undocumented?) behavior since 4.54.0.

To Reproduce

Steps to reproduce the behavior:

1. Go to 'https://design.infor.com/code/ids-enterprise/4.54.0/demo/components/modal/example-index' or any later versions
2. Click on 'Show Modal', optionally write something in the first input field
3. Press Enter
4. The dialog closes

Expected behavior
When repeating the above, but on 4.53.5 the dialog is not closed.

Version

• ids-enterprise: 4,54,0 to current latest

Platform

• Browser Name: Chrome

Additional context
Causing some issues in multiple projects and dialogs, especially where "Enter" is handled in an unexpected way, for example an Autocomplete field where no value has been selected:

https://jira.infor.com/browse/LIME-7118
https://jira.infor.com/browse/MINGLEDEV-32468

[tmcconechy]

Yes it was be design. It was not working so we fixed it. See #5198

We could make it an option though? But this is like normal alert dialogs where it triggers the primary

[anhallbe]

Okay thanks for the info @tmcconechy !

I guess it makes sense as a default. I think our issue is mainly that in some cases the "enter keypress" event bubbles up to the dialog unexpectedly (e.g an Autocomplete where no value is selected). But that's a separate issue.

Although I also guess it could be nice to be able to disable it, since it might be annoying when there's a modal with many fields, some of which requires "enter" to fill them out (textarea, dropdowns etc), while others will accidentally close the dialog.

[tmcconechy]

Sure, if enter in textarea and dropdown closes it that would be a bug.. But we made exceptions for these https://main-enterprise.demo.design.infor.com/components/modal/example-index.html

Yes, i think we could just make this an option

[nganotice]

This has been QA tested and passed on v4.58.0-dev.

https://main-enterprise.demo.design.infor.com/components/modal/example-index.html

Moving this ticket to Done.

Thanks!