Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datagrid: Tree list indentation is not left aligned when row has no children and datagrid row height is extra small #5487

Closed
krishollenbeck opened this issue Aug 3, 2021 · 1 comment · Fixed by #5516
Closed

Datagrid: Tree list indentation is not left aligned when row has no children and datagrid row height is extra small #5487

krishollenbeck opened this issue Aug 3, 2021 · 1 comment · Fixed by #5516
Assignees
@andriivarhanov
Labels
team: landmark For Landmark issues type: bug 🐛 [3] Velocity rating (Fibonacci)
Projects
Enterprise 4.55.x (Aug 2021) Sprint

Comments

@krishollenbeck
Copy link
Contributor

Describe the bug
Tree list indentation is off when row has no children and datagrid row height is extra small.

To Reproduce

Steps to reproduce the behavior:

  1. Modify test-post-renderer-tree.html and add the following option. rowHeight: 'extra-small'
  2. Go to test-post-renderer-tree.html
  3. Notice the left alignment is off when a row has no children. It makes it appear as if they are children of the previous row when they aren't.

Expected behavior
Row values should left align properly.

Version
4.38.0-dev, 4.52.2

Screenshots
extra-small-row-height-tree-indent-issue
extra-small-row-height-tree-indent-issue-1

Platform

  • Landmark
  • Windows 10
  • Chrome
  • 92.0.4515.131
@krishollenbeck krishollenbeck changed the title Tree list indentation is off when row has no children and datagrid row height is extra small Tree list indentation is not left aligned row has no children and datagrid row height is extra small Aug 3, 2021
@krishollenbeck krishollenbeck changed the title Tree list indentation is not left aligned row has no children and datagrid row height is extra small Tree list indentation is not left aligned when row has no children and datagrid row height is extra small Aug 3, 2021
@tmcconechy tmcconechy added [3] Velocity rating (Fibonacci) team: landmark For Landmark issues type: bug 🐛 labels Aug 3, 2021
@tmcconechy tmcconechy changed the title Tree list indentation is not left aligned when row has no children and datagrid row height is extra small Datagrid: Tree list indentation is not left aligned when row has no children and datagrid row height is extra small Aug 3, 2021
@tmcconechy tmcconechy added this to Triage in Enterprise (Next) Sprint Grooming via automation Aug 3, 2021
andriivarhanov added a commit that referenced this issue Aug 13, 2021
@andriivarhanov
Fix datagrid tree list indentation doesn't apply after row height opt…
b303e63 
…ions changed from short to small/extra-small. #5487
@andriivarhanov andriivarhanov mentioned this issue Aug 13, 2021
Merged
2 tasks
@tmcconechy tmcconechy added this to To do in Enterprise 4.56.x (Sept 2021) Sprint via automation Aug 16, 2021
@tmcconechy tmcconechy moved this from To do to Pending Review in Enterprise 4.56.x (Sept 2021) Sprint Aug 16, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.55.x (Aug 2021) Sprint via automation Aug 16, 2021
andriivarhanov added a commit that referenced this issue Aug 16, 2021
@andriivarhanov
Add baseline images. #5487
7b01451
andriivarhanov added a commit that referenced this issue Aug 16, 2021
@andriivarhanov
Add note to the change log. #5487
d55fdb8
@tmcconechy tmcconechy moved this from To do to Pending Review in Enterprise 4.55.x (Aug 2021) Sprint Aug 19, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.55.x (Aug 2021) Sprint Aug 19, 2021
@nganotice
Copy link

This has been QA tested and passed on v4.55.0-dev.

https://main-enterprise.demo.design.infor.com/components/datagrid/example-tree.html
https://main-enterprise.demo.design.infor.com/components/datagrid/test-tree-editable.html
https://main-enterprise.demo.design.infor.com/components/datagrid/test-tree-export.html
https://main-enterprise.demo.design.infor.com/components/datagrid/test-post-renderer-tree.html
Screen Shot 2021-08-20 at 5 18 54 PM

Moving this ticket to Done.

Thanks!

@nganotice nganotice moved this from Ready for QA (beta) to Done in Enterprise 4.55.x (Aug 2021) Sprint Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andriivarhanov andriivarhanov

Labels
team: landmark For Landmark issues type: bug 🐛 [3] Velocity rating (Fibonacci)
Projects
No open projects
Enterprise 4.55.x (Aug 2021) Sprint
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

5487 - Datagrid: Tree list indentation is not left aligned infor-design/enterprise
4 participants
@tmcconechy @krishollenbeck @andriivarhanov @nganotice