Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message: Mobile Enhancements and style changes #5567

Closed
4 tasks
tmcconechy opened this issue Aug 31, 2021 · 8 comments · Fixed by #5724 or #5767
Closed
4 tasks

Message: Mobile Enhancements and style changes #5567

tmcconechy opened this issue Aug 31, 2021 · 8 comments · Fixed by #5724 or #5767
Assignees
Labels
focus: mobile Main focus is mobile improvements type: enhancement ✨ [3] Velocity rating (Fibonacci)

Comments

@tmcconechy
Copy link
Member

tmcconechy commented Aug 31, 2021

Describe the bug
Design working on mobile enhancements came up with some changes.

Fixes
https://www.figma.com/file/WyznaRH0lS6rndjjGeSOen/Message?node-id=0%3A1

  • Change modal-body-wrapper padding to 32px top and bottom, 16px left and right (all sizes)
  • modal header should have padding top of 24px, bottom 0, and 16px left and right (all sizes)
  • On the lowest breakpoint the message should have only 16px on each side (with a minWidth as before)
  • Make these changes on the web component too

For the breaking points (no 2) looks like

  • .modal-content -> margin t 16px
  • .modal -> to 100%

Additional context
Please fix this in the web components too on a seperate PR.

@tmcconechy tmcconechy added [3] Velocity rating (Fibonacci) type: enhancement ✨ labels Aug 31, 2021
@tmcconechy tmcconechy added this to Triage in Enterprise (Next) Sprint Grooming via automation Aug 31, 2021
@tmcconechy tmcconechy added the focus: mobile Main focus is mobile improvements label Aug 31, 2021
@tmcconechy tmcconechy moved this from Triage to Ready For Dev in Enterprise (Next) Sprint Grooming Sep 10, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.57.x (Oct 2021) Sprint via automation Sep 29, 2021
@tmcconechy tmcconechy removed this from Ready For Dev in Enterprise (Next) Sprint Grooming Sep 29, 2021
@ericangeles
Copy link
Contributor

Figma link doesn't work.

@tmcconechy
Copy link
Member Author

Works for me.. i'll ping this to design...

@jbrcna
Copy link
Contributor

jbrcna commented Oct 21, 2021

Hello, using dimension 600 x 596 , the padding is till 4px, 16px
Expected result: modal-body-wrapper should be padding: 4px 24px

image

@jbrcna jbrcna moved this from Ready for QA (beta) to Failed QA (beta) in Enterprise 4.57.x (Oct 2021) Sprint Oct 21, 2021
@tmcconechy
Copy link
Member Author

The design doesnt 100% explain the padding above and below the text but its not 16px in the design so checking...On it
Screen Shot 2021-10-21 at 9 53 30 AM

@tmcconechy
Copy link
Member Author

Specs for this added to https://www.figma.com/file/WyznaRH0lS6rndjjGeSOen/Message?node-id=0%3A1 (32px there)
cc @ericangeles

@ericangeles
Copy link
Contributor

@tmcconechy so the 16px will no longer apply on mobile? I remember we had discussions about the padding sizes. 24px will apply to all sizes?

@ericangeles ericangeles moved this from Failed QA (beta) to In progress in Enterprise 4.57.x (Oct 2021) Sprint Oct 21, 2021
@tmcconechy
Copy link
Member Author

tmcconechy commented Oct 21, 2021

Its 16px left and right of the text and 32px above and below the text (we didnt spec the above and below until @jbrcna noticed an inconsistency). And this can go on both desktop and mobile (all sizes)

So we just need to fix the 32px above/below

@ericangeles ericangeles moved this from In progress to Pending Review in Enterprise 4.57.x (Oct 2021) Sprint Oct 21, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.57.x (Oct 2021) Sprint Oct 22, 2021
@CindyMercadoReyes
Copy link
Collaborator

This issue is now resolved.

@CindyMercadoReyes CindyMercadoReyes moved this from Ready for QA (beta) to Done in Enterprise 4.57.x (Oct 2021) Sprint Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: mobile Main focus is mobile improvements type: enhancement ✨ [3] Velocity rating (Fibonacci)
Projects
No open projects
4 participants