Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge Chromium has "ie" css class #5587

Closed
tfavorite opened this issue Sep 8, 2021 · 2 comments · Fixed by #5779
Closed

Edge Chromium has "ie" css class #5587

tfavorite opened this issue Sep 8, 2021 · 2 comments · Fixed by #5779
Assignees
Labels
focus: chromium-edge Main focus is fixes for new chromium edge browser type: bug 🐛 [2] Velocity rating (Fibonacci)

Comments

@tfavorite
Copy link
Contributor

Describe the bug
Edge Chromium is inappropriately categorized as IE. We have some IE stylesheets we use for IE11 CSS workarounds, and now Edge includes them. This seems to have changed in a5a6764

To Reproduce
Load a page in Edge Chromium (I have version 93.0.961.38), e.g.: https://design.infor.com/code/ids-enterprise/latest/demo/components/button/example-index?theme=uplift&variant=light
Note that html class includes "ie" even though Edge Chromium is not ie: is-chrome is-mac ie ie-edge ie-edge17 theme-new-light

Expected behavior
Edge should not include the "ie" class.

Version

  • ids-enterprise: 4.54.1

Platform

  • Infor Application/Team Name: Nexus

Additional context
We can work around this by wrapping our IE rules with ".ie:not(.ie-edge)", but this seemed like a bug that should get raised to IDS Engineering.

@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) focus: chromium-edge Main focus is fixes for new chromium edge browser type: bug 🐛 labels Sep 8, 2021
@tmcconechy tmcconechy added this to Triage in Enterprise (Next) Sprint Grooming via automation Sep 8, 2021
@tmcconechy
Copy link
Member

cc @andriivarhanov - heads up on this one as its probably in the new device specs

@jbrcna
Copy link
Contributor

jbrcna commented Oct 28, 2021

This has been QA tested and passed on v4.57.0-dev.

edge
image

chrome
image

firefox
image

IE (browserstack) This has been QA tested and passed on v4.55.0-dev.
image

safari
image

@jbrcna jbrcna moved this from Ready for QA (beta) to Done in Enterprise 4.57.x (Oct 2021) Sprint Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: chromium-edge Main focus is fixes for new chromium edge browser type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants