Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About: Copying content enhancement #8438

Closed
hey-yall opened this issue Feb 13, 2024 · 14 comments · Fixed by #8589
Closed

About: Copying content enhancement #8438

hey-yall opened this issue Feb 13, 2024 · 14 comments · Fixed by #8589
Assignees
Labels
type: bug 🐛 [3] Velocity rating (Fibonacci)

Comments

@hey-yall
Copy link
Collaborator

hey-yall commented Feb 13, 2024

Is your feature request related to a problem or use case? Please describe.
This was requested during the workshop

Please fix the copy behavior in the About dialog. Currently functionality copies all background information. Users need a way to easily copy the About info to paste into other applications.

Describe the solution you'd like
Please provide a solution so that Ctrl + A and copying only pulls the content within the About feature and not the background info

Describe alternatives you've considered
We discussed having a Copy button placed in the component, but decided that updating the Ctrl + C functionality would be best for consumers.

Additional context
Tracked under Jira ticket https://inforwiki.atlassian.net/browse/IDS-1591

@tmcconechy tmcconechy added type: bug 🐛 [3] Velocity rating (Fibonacci) labels Feb 13, 2024
@tmcconechy
Copy link
Member

May also need this to add this #8414

@hey-yall
Copy link
Collaborator Author

hey-yall commented Apr 3, 2024

@tmcconechy Hi Tim! Please help me understand if this issue has been solved. I see #8414 is closed, but does that mean the Ctrl + C functionality in the About modal has also been updated?

@tmcconechy
Copy link
Member

@hey-yall i missed this issue. Its not solved but i also dont really understand it.

  1. Go to https://main-enterprise.demo.design.infor.com/components/about/example-index.html
  2. select all the text in the text area (or the parts you want) and hit CTRL+C and that works if you paste it

Can you clarify the issue (if you want a button to do it we would have to add that but doing CTRL+C already works)

@karinpb
Copy link

karinpb commented Apr 4, 2024

@tmcconechy If you read the ticket again support get screenshots of the about dialog and would like a better way to copy the information. A button or link to copy might at least get some users to not just printscreen and then not everything is visible. Or should you increase the size of the dialog? Important information is in the bottom and selecting HTML does not seem like a viable solution that people would use. I also don't think that a user would just ctrl+c and expect text to be copied on the dialog. I would printscreen it unless there was some link or button to click to copy the information that I would see.

So when you always get this:
image
But you are interested in all the information at the buttom and you need to ask them again becuase they didn't scroll then that would be my interpretation of the ask. Perhaps making the dialog bigger would be the best approach, but I hope that gives more context.

@hey-yall
Copy link
Collaborator Author

hey-yall commented Apr 4, 2024

Hi @karinpb, thank you for the additional information! The product team will address adding buttons to the About modal in a future iteration of the design system. Right now, the quickest fix is to rewrite the Copy/Paste functionality to only capture relevant data.

@tmcconechy -- Currently, when the user copies all About modal info via Ctrl + A and Ctrl + C, it also copies background information outside the modal. See this pic for explanation:

Screenshot 2024-04-04 at 7 52 50 AM

For the current iteration, can we fix the Ctrl + A and Ctrl + C functionality so it selects/copies only the info set in the scrollable textarea? This would be a quick win for users copying the About info. Thanks!

@tmcconechy
Copy link
Member

@hey-yall you need to click in and select it. Its a bit awkward. But we cant really control what the user selects.

Screenshot 2024-04-04 at 10 13 21 AM

I think we could do the following

  • make it taller (remove any uneeded info)
  • add a copy button (easy just need placement and a icon selection)
  • could try and make it select all the text when you click on it to make it easier (possible "quick win")

So i suggest we go ahead with the design changes and expediate them if this is a big issue.

@hey-yall
Copy link
Collaborator Author

hey-yall commented Apr 4, 2024

@tmcconechy and @karinpb -- Discussed with the design team and will add a button. Designating as high priority. Tracking design work in associated Jira ticket https://inforwiki.atlassian.net/browse/IDS-1591.

@hey-yall
Copy link
Collaborator Author

hey-yall commented Apr 4, 2024

Hi @tmcconechy ! Please move forward with this issue!

Add a Copy icon button below the textarea on the right side of the About modal.

Please let me know if you have any questions. Thanks!

@tmcconechy
Copy link
Member

@hey-yall where should we show it ? Here:

Screenshot 2024-04-04 at 2 40 15 PM

@tmcconechy
Copy link
Member

@hey-yall for mobile reasons might work better around here:
Screenshot 2024-04-04 at 2 52 08 PM

@tmcconechy tmcconechy self-assigned this Apr 4, 2024
@hey-yall
Copy link
Collaborator Author

hey-yall commented Apr 4, 2024

@tmcconechy Designers want it below the textarea on the right side, where the red arrow is pointing. Like this:

319735862-bcbb2453-de16-4092-a2a1-ab2320f1a28c

@tmcconechy
Copy link
Member

@hey-yall
Copy link
Collaborator Author

Approved. Great work!

@glenlieorillo
Copy link
Contributor

This has been tested and passed.

Screen.Recording.2024-04-11.at.4.46.01.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 [3] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants