Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8438 - Added copy to clipboard button to about page #8589

Merged
merged 4 commits into from
Apr 5, 2024
Merged

Conversation

tmcconechy
Copy link
Member

Explain the details for making this change. What existing problem does the pull request solve?

Adds a copy button to the about page.

Related github/jira issue (required):
Fixes #8438

Steps necessary to review your pull request (required):

Included in this Pull Request:

  • A note to the change log.

@tmcconechy tmcconechy requested a review from a team as a code owner April 4, 2024 19:12
glenlieorillo
glenlieorillo previously approved these changes Apr 5, 2024
Copy link
Contributor

@glenlieorillo glenlieorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Mac Chrome
Screen.Recording.2024-04-05.at.2.52.21.PM.mov
  • Mac Firefox
Screen.Recording.2024-04-05.at.2.54.46.PM.mov
  • Safari
Screen.Recording.2024-04-05.at.2.53.32.PM.mov

ericangeles
ericangeles previously approved these changes Apr 5, 2024
jbrcna
jbrcna previously approved these changes Apr 5, 2024
Copy link
Contributor

@jbrcna jbrcna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image image image image

@tmcconechy
Copy link
Member Author

Just waiting on design feedback on the Button position.

@tmcconechy tmcconechy merged commit c68b80e into main Apr 5, 2024
2 checks passed
@tmcconechy tmcconechy deleted the about-copy branch April 5, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About: Copying content enhancement
4 participants