Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2722 - Add Fontpicker Component to Editor #3219

Merged
merged 9 commits into from
Dec 11, 2019
Merged

Conversation

EdwardCoyle
Copy link
Contributor

Explain the details for making this change. What existing problem does the pull request solve?
This PR adds a new Fontpicker component to IDS. The Fontpicker has been integrated into the Editor component, and takes the place of the h3 and h4 buttons that previously existed.

Related github/jira issue (required):
Closes #2722

Steps necessary to review your pull request (required):

There are also a handful of new functional tests for this component that should all pass.

Included in this Pull Request:

  • An e2e or functional test for the bug or feature.
  • A note to the change log.

@EdwardCoyle
Copy link
Contributor Author

@Fruko if you're able, would you mind testing this in your environment to see if it meets your requirements?

@Fruko
Copy link

Fruko commented Dec 10, 2019

@EdwardCoyle sure, the branch or after it's merged to master?

@tmcconechy
Copy link
Member

@Fruko Either way. But if you do try the branch and find some suggestions we can get them in sooner before merged. But either will help.

@tmcconechy
Copy link
Member

Screen Shot 2019-12-11 at 12 01 37 PM

  • should we move the arrow closer? or is that the design?

Screen Shot 2019-12-11 at 12 02 41 PM

- should this one have an arrow?

@EdwardCoyle
Copy link
Contributor Author

The design put some extra space between the text and the arrow.

I'm not sure why the in-page one doesn't have the arrow... I can look into it

@tmcconechy tmcconechy merged commit 5597395 into master Dec 11, 2019
@tmcconechy tmcconechy deleted the 2722-add-fontpicker branch December 11, 2019 21:32
@Fruko
Copy link

Fruko commented Dec 13, 2019

Sorry for the delay, the changes are good for our use case. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor: Configuring heading buttons is not working
3 participants