Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3337 - Fix date range filter with datagrid #3539

Merged
merged 5 commits into from
Feb 28, 2020

Conversation

deep7102
Copy link
Contributor

@deep7102 deep7102 commented Feb 25, 2020

Explain the details for making this change. What existing problem does the pull request solve?
Fixed some date range issues with Datagrid, Datepicker and Field Filter.

Related github/jira issue (required):
Closes #3337
Closes #3503
Closes #1306
Closes #3268
Closes #2764
Closes #3515

Steps necessary to review your pull request (required):
Pull this branch and build/run the demo app

#3337

#3503

  • http://localhost:4000/components/datagrid/example-filter.html
  • Change the operator to in-range for the Order Date column filter
  • Type directly in to filter input 01/01/2015 - 06/05/2015
  • See it should let enter both range dates
  • Clear the date value
  • Attempt to pick the date range via the date picker
  • See it should let pick both range dates

#1306

#3268

#2764

#3515

Included in this Pull Request:

  • A note to the change log.

@deep7102 deep7102 requested a review from a team February 25, 2020 20:22
EdwardCoyle
EdwardCoyle previously approved these changes Feb 26, 2020
@tmcconechy
Copy link
Member

I'm thinking we should probably fix #3503 too because it is not possible to type in the mask past the dash. actually there is a bunch of range issues https://github.com/infor-design/enterprise/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+range

@deep7102
Copy link
Contributor Author

Hi @tmcconechy updated now, to fix the other related issues.

tmcconechy
tmcconechy previously approved these changes Feb 28, 2020
Copy link
Member

@tmcconechy tmcconechy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work on this one @deep7102 squished out a lot of 🐛

EdwardCoyle
EdwardCoyle previously approved these changes Feb 28, 2020
@tmcconechy tmcconechy dismissed stale reviews from EdwardCoyle and themself via 1a30c89 February 28, 2020 17:38
@tmcconechy tmcconechy merged commit 68f6666 into master Feb 28, 2020
@tmcconechy tmcconechy deleted the 3337-datagrid-range-datepicker branch February 28, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment