Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5096 - Tabs Searchfield Close Button Resize/Fixes #5103

Merged
merged 5 commits into from
Apr 19, 2021

Conversation

rob2d
Copy link
Contributor

@rob2d rob2d commented Apr 16, 2021

Explain the details for making this change. What existing problem does the pull request solve?

Search fields related to tabs had regression on close button; but also there was another issue where content of search field was not resizing. This is separate from the visual cutoff issue which pre-existed with the search field in tab headers (out of scope of PR).

Related github/jira issue (required):

Closes #5096 .

Steps necessary to review your pull request (required):

Included in this Pull Request:

  • An e2e or functional test for the bug or feature.
  • A note to the change log.

Implementation note: added resize trigger vs added logic to handler since another PR in review changes the existing callback to only check for breakpoint change event vs window resize as fix (to prevent any merge mistakes). So this change wouldn't be redundant once existing with that.

@rob2d rob2d requested a review from a team as a code owner April 16, 2021 21:45
Copy link
Member

@tmcconechy tmcconechy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rob2d - these seems fine as is , FYI i added a line of code so the theme switcher works in this example. When i did i saw that the text is a little offline in classic theme (sits a bit high)

If you want to add a fix - thats up to you. Willing to let it go in the interest of priorities/time...

Screen Shot 2021-04-19 at 9 42 56 AM

@rob2d
Copy link
Contributor Author

rob2d commented Apr 19, 2021

@tmcconechy thanks for catching that/adding the theme fix. I tweaked the offset between classic/new also since that was very specific/quick to target on this branch.

@rob2d rob2d force-pushed the 5096-tab-container-searchfield-close-button-fixes branch from 63ea2df to be60520 Compare April 19, 2021 18:21
@tmcconechy tmcconechy merged commit 8882b23 into main Apr 19, 2021
@tmcconechy tmcconechy deleted the 5096-tab-container-searchfield-close-button-fixes branch April 19, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs: Search field close button looks off or not aligned
3 participants