Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6868 - Fix additional icon issues #6935

Merged
merged 17 commits into from
Nov 8, 2022
Merged

6868 - Fix additional icon issues #6935

merged 17 commits into from
Nov 8, 2022

Conversation

tmcconechy
Copy link
Member

@tmcconechy tmcconechy commented Nov 1, 2022

Explain the details for making this change. What existing problem does the pull request solve?
Additional fix(s) for the icon changes - may add to this as QA works

Related github/jira issue (required):
#6868
Fixes #6934

Steps necessary to review your pull request (required):

@tmcconechy tmcconechy requested a review from a team as a code owner November 1, 2022 16:59
ericangeles
ericangeles previously approved these changes Nov 2, 2022
@tmcconechy
Copy link
Member Author

Expecting a new fix shortly

@ericangeles
Copy link
Contributor

Open for review now @tmcconechy ?

Copy link
Contributor

@ericangeles ericangeles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, except for error-icon position. All icons are okay in classic.

Screen Shot 2022-11-07 at 4 22 23 PM

@tmcconechy tmcconechy changed the title 6868 - Fix icon fallout 6868 - Fix additional icon issues Nov 7, 2022
@tmcconechy
Copy link
Member Author

All set here. Will make beta tomorrow

ericangeles
ericangeles previously approved these changes Nov 8, 2022
@tmcconechy tmcconechy merged commit 4a3553d into main Nov 8, 2022
@tmcconechy tmcconechy deleted the fix-icon-fallout branch November 8, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icons: Add new empty states
2 participants